Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #134

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

ianrrees
Copy link
Contributor

If #133 is accepted, this should have the explicit use for LangID removed from the example code.

src/lib.rs Outdated Show resolved Hide resolved
@ianrrees ianrrees force-pushed the doc-update branch 2 times, most recently from 22204d2 to 808b1a4 Compare November 15, 2023 04:09
@ianrrees
Copy link
Contributor Author

I've force-pushed changes to bump the patch version.

Also can report that the tests pass on ATSAMD21 and ATSAMD51 boards when using a branch of the HAL that has a couple minor updates to work with the newer usb-device. Once the HAL changes are merged, I'll aim to get back to #100

@ithinuel
Copy link
Contributor

Hello, can we use this opportunity to make BuilderError public or does it need it's own PR?

@ianrrees
Copy link
Contributor Author

Sounds good to me! @ithinuel does the new commit work for your purpose?

CHANGELOG.md Show resolved Hide resolved
@ithinuel
Copy link
Contributor

It does, thank you 👍

Copy link
Member

@ryan-summers ryan-summers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I'll release here when I get in the office :) thanks for the updates!

@ianrrees
Copy link
Contributor Author

Sorry to throw this in at the last minute (and end of a long day for me - apologies if this doesn't make sense!) but I'm wondering if BuilderError is maybe too generic of a name, for something that is put in the prelude - lots of things use Builder... Maybe UsbBuilderError, or a super-verbose UsbDeviceBuilderError?

@ryan-summers
Copy link
Member

If people don't like the name, they can rename it during import. The same argument can be made for Error

@ryan-summers ryan-summers merged commit 7d2b12a into rust-embedded-community:master Nov 15, 2023
3 checks passed
@ianrrees ianrrees deleted the doc-update branch November 15, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants